Comments on: GWT XML Indenter/Formatter http://hawflakes.unoc.net/?p=79 Side Projects, Hobbies, Media, Fun Thu, 01 Jul 2010 19:43:25 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Jon http://hawflakes.unoc.net/?p=79&cpage=1#comment-16 Jon Mon, 05 Jan 2009 09:06:30 +0000 http://hawflakes.unoc.net/?p=79#comment-16 Thanks a lot for the comments. Just some comments and some questions. <blockquote cite="#commentbody-14"> Lack of spaces between concatenations and parameter separations. Lack of temporary variable / for each loop (dunno if that’s possible here, my Java knowledge is limited) in the attribute loop. </blockquote> Some of these are partly due to the way my wordpress formatter is misbehaving. It didn't like the "< " in my for loops. The others are simply that I was lazy. I just wanted to make the snippet available. It's not optimized at all. Just short and easy to understand. Temporary variables would certainly make it more efficient, but to me it makes the code a little harder to just skim through. The attribute loop is actually an unfortunate circumstance of java. In IE, it seems to work well if I just run getAttributes().toString(). However in Firefox, it lacks the necessary spaces between each of the attributes, and so I resorted to adding in an extra loop. In case anyone wants to fix the snippet and use temporary variables, you should probably reference the NodeMap of attributes, perhaps in addition to referencing to the attribute node. <blockquote cite="#commentbody-15"> <p>Well for one you might want to use a StringBuilder.</p> I would be interesting in seeing if anyone has run any tests on String vs StringBuilder in GWT. In theory StringBuilder should be more efficient, but I'm not sure how it's been implemented in javascript. Either way, it's probably more memory efficient, which I should probably keep in mind because GWT can get somewhat heavy. Thanks a lot for the comments.

Just some comments and some questions.

Lack of spaces between concatenations and parameter separations.

Lack of temporary variable / for each loop (dunno if that’s possible here, my Java knowledge is limited) in the attribute loop.

Some of these are partly due to the way my wordpress formatter is misbehaving. It didn’t like the “< " in my for loops. The others are simply that I was lazy. I just wanted to make the snippet available. It's not optimized at all. Just short and easy to understand.

Temporary variables would certainly make it more efficient, but to me it makes the code a little harder to just skim through. The attribute loop is actually an unfortunate circumstance of java. In IE, it seems to work well if I just run getAttributes().toString(). However in Firefox, it lacks the necessary spaces between each of the attributes, and so I resorted to adding in an extra loop. In case anyone wants to fix the snippet and use temporary variables, you should probably reference the NodeMap of attributes, perhaps in addition to referencing to the attribute node.

Well for one you might want to use a StringBuilder.

I would be interesting in seeing if anyone has run any tests on String vs StringBuilder in GWT. In theory StringBuilder should be more efficient, but I’m not sure how it’s been implemented in javascript. Either way, it’s probably more memory efficient, which I should probably keep in mind because GWT can get somewhat heavy.

]]> By: Auke http://hawflakes.unoc.net/?p=79&cpage=1#comment-15 Auke Sat, 03 Jan 2009 22:34:03 +0000 http://hawflakes.unoc.net/?p=79#comment-15 Well for one you might want to use a StringBuilder. Well for one you might want to use a StringBuilder.

]]> By: Mark S. Rasmussen http://hawflakes.unoc.net/?p=79&cpage=1#comment-14 Mark S. Rasmussen Sat, 03 Jan 2009 17:06:54 +0000 http://hawflakes.unoc.net/?p=79#comment-14 As for code style I'd prefer something like this (semi-pseudo code): http://pastebin.com/f7f14bbbf I really dislike the inconsistent usage of curlies. Lack of spaces between concatenations and parameter separations. Lack of temporary variable / for each loop (dunno if that's possible here, my Java knowledge is limited) in the attribute loop. As for code style I’d prefer something like this (semi-pseudo code):
http://pastebin.com/f7f14bbbf

I really dislike the inconsistent usage of curlies. Lack of spaces between concatenations and parameter separations. Lack of temporary variable / for each loop (dunno if that’s possible here, my Java knowledge is limited) in the attribute loop.

]]> By: Jon http://hawflakes.unoc.net/?p=79&cpage=1#comment-13 Jon Thu, 01 Jan 2009 22:53:05 +0000 http://hawflakes.unoc.net/?p=79#comment-13 <a href="#comment-12" rel="nofollow">@caustic</a> It would be nice if you explained your comment, it's somewhat unclear how I should make improvements. @caustic
It would be nice if you explained your comment, it’s somewhat unclear how I should make improvements.

]]> By: caustic http://hawflakes.unoc.net/?p=79&cpage=1#comment-12 caustic Thu, 01 Jan 2009 17:50:57 +0000 http://hawflakes.unoc.net/?p=79#comment-12 Your code would not pass my review. Your code would not pass my review.

]]>